On Wed, Feb 29, 2012 at 09:21:34AM +0100, jolly wrote:
hi,
Hi jolly,
i have tested it with several configurations. i would like to commit it to master. any suggestions?
Do you remember your test setup and the results of it? There appears to be an issue with iPhone4s and iPhone5 phones (and PCS). It appears to me that there are at least three issues with the generation:
* The SI1 rest_octets indicated DCS while PCS was used (this is fixed) * The Ext-Ind claims that SI2 carries the complete BA even if SI2ter/2bis are scheduled. * The BA-Ind is the same for SDCCH/BCCH. We should use 0/1.
Could you have a look at it?
thanks holger
Holger Hans Peter Freyther wrote:
- The SI1 rest_octets indicated DCS while PCS was used (this is fixed)
yes, i missed that. but IIRC, it must be set on non-PCS cells (i.a. 850 or 900) to indicate whether neighbor ARFCN of 512... refer to PCS. on a PCS BTS it should be ignored by MS.
you should check if there the network that has all PCS or all DCS BTS and then set this bit or not. even on GSM 900 cells this bit must be set, if there is/are all PCS BTS. if there are both PCS and DCS BTS, there should be a warning, because this is not allowed.
- The Ext-Ind claims that SI2 carries the complete BA even if SI2ter/2bis are scheduled.
look at generate_si2bis: (si5bis respectively)
if (n) ... si2->bcch_frequency_list[0] |= 0x20; si2b->bcch_frequency_list[0] |= 0x20;
if there are frequencies defined in si2bis, the EXT-IND is set on both (si2 and si2bis) lists. if not, the si2bis is removed and not transmitted.
- The BA-Ind is the same for SDCCH/BCCH. We should use 0/1.
if both lists differ, it makes sense to have different BA-IND. currently there is no difference, but it is not wrong to set BA-IND on SI5*.
On Mon, Mar 11, 2013 at 07:50:43AM +0100, jolly wrote:
yes, i missed that. but IIRC, it must be set on non-PCS cells (i.a. 850 or 900) to indicate whether neighbor ARFCN of 512... refer to PCS. on a PCS BTS it should be ignored by MS.
right, as PCS/DCS is not allowed I take a look during the SI generation and check if that bts is a DCS/PCS unit and set the indicator.
In terms of VTY we need to add consistency checks at the time of a 'write' call and after loading. But this is not limited to the DCS/PCS code.
if (n) ... si2->bcch_frequency_list[0] |= 0x20; si2b->bcch_frequency_list[0] |= 0x20;
if there are frequencies defined in si2bis, the EXT-IND is set on both (si2 and si2bis) lists. if not, the si2bis is removed and not transmitted.
true. I was confused and thought EXT-IND is set for SI2ter as well. But this is signalled in the SI3 rest octets. SI5ter doesn't appear to be signalled at all.
greetings from Iceland holger
-
Holger Hans Peter Freyther -
jolly