I rebased the recent openbsc.git patches to osmo-msc.git and am submitting all of them on gerrit, to make sure each passes the tests. Since they are already accepted on openbsc.git, I'll also directly +2 and merge them.
We will be re-using the same Change-Ids from openbsc.git, and I checked: if multiple commits match the same change-id, a search on gerrit will simply list all matches, so we're not losing any information.
https://gerrit.osmocom.org/#/q/Ie7cdf16232181d4b8093e61f2d8a3faed9010d4f
~N
On Thu, Aug 24, 2017 at 07:40:27PM +0200, Neels Hofmeyr wrote:
I rebased the recent openbsc.git patches to osmo-msc.git and am submitting all of them on gerrit, to make sure each passes the tests. Since they are already accepted on openbsc.git, I'll also directly +2 and merge them.
Thanks, that's great.
How to proceed with the split? Should we review patches that are failing (-V), or should we wait until they actually build?
On Thu, Aug 24, 2017 at 10:51:14PM +0200, Harald Welte wrote:
On Thu, Aug 24, 2017 at 07:40:27PM +0200, Neels Hofmeyr wrote:
I rebased the recent openbsc.git patches to osmo-msc.git and am submitting all of them on gerrit, to make sure each passes the tests. Since they are already accepted on openbsc.git, I'll also directly +2 and merge them.
Thanks, that's great.
How to proceed with the split? Should we review patches that are failing (-V), or should we wait until they actually build?
There have been some odd failures that seem related to build host / docker issues rather than the code itself: only patches in the middle failed, subsequent ones succeeded, which indicates sporadic failure.
In the end I decided to check that the final result of all openbsc.git news added to osmo-msc.git builds, and then merged all of the patches to osmo-msc master ... for the benefit of getting on with the actual new patches.
About those, there are still some without-iu build errors, odd "Broken Pipe" failures and vty tests failures. I'm battling gerrit and jenkins windmills to finally verify them.
~N
-
Harald Welte -
Neels Hofmeyr