Hi Oliver,

since osmo-dev isn't critical for users but more our own corner of the workshop, I would invite you to merge your changes without waiting for code review. If something breaks for me we can still discuss and tweak it later.

I appreciate that osmo-dev is useful to you and that you are expanding it! I'd like to make life easier for you in that regard. IIUC you have permission to push to master directly, please do.

~N

On Thu, Mar 10, 2022 at 03:15:10PM +0100, Oliver Smith wrote:

Hey Neels, and potentially other users of osmo-dev.git reading the ML,

since I'm using osmo-dev's net scripts to test OsmoBSCNAT while developing it, I submitted patches with significant changes that make testing easier/possible:

• config_mine is now a diff to config_2g3g
• optionally build mobile + virtphy from osmocom-bb.git
• optionally start BSC2, virtual BTS, virtual MS
• all cmds can be overwritten in config_mine now, without modifying run.sh

(e.g. to use valgrind, CMD_BSCNAT="valgrind osmo-bsc-nat")

Patches were submitted for review here: https://gerrit.osmocom.org/c/osmo-dev/+/27432/1

Related osmo-bsc-nat patches: https://gerrit.osmocom.org/c/osmo-bsc-nat/+/27461

Best, Oliver --

• Oliver Smith osmith@sysmocom.de https://www.sysmocom.de/

=======================================================================

• sysmocom - systems for mobile communications GmbH
• Alt-Moabit 93
• 10559 Berlin, Germany
• Sitz / Registered office: Berlin, HRB 134158 B
• Geschaeftsfuehrer / Managing Director: Harald Welte