On 08 Mar 2016, at 14:12, Neels Hofmeyr
<nhofmeyr(a)sysmocom.de> wrote:
On Mon, Mar 07, 2016 at 10:14:10PM +0100, Holger Freyther wrote:
Could we get a consensus how we know where to
apply the patch to?
I had basically the same question when I started in the osmocom code a
while back. It was mostly for not having to search around to understand
the context. That problem is by now pretty much "fixed", I mostly know
what's going on and anyway have a ctags file across all the git
repositories to find things easily...
I thought we had "From: hash.." or such in git send-email but maybe that was
never the case (I wonder how git am -3 patch is implemented then). When using git
format-patch there is a from (e.g. From 9b090fd5ab2f6b36a60b41a4f4ac9bd435f18582 Mon Sep
17 00:00:00 2001) but not in the patchwork.. hmm
The based-on-parent-hash approach sounds like a good solution for robots?
But I'm not sure how that works in detail. Are we talking about this?
index d9d7390..47f3fa7 100644
It seems to be the hash for the file object, not the parent commit.
So one could look for this hash in the git objects database...?
openbsc ich$ git cat-file -t d9d7390
blob
so that file is in OpenBSC.. now if the _same_ file is in two repositories we have an
issue. :)
It should definitely be something that works automatically, because we
*will* forget anything that must be remembered manually.
git config --local format.subjectprefix "libosmocore][PATCH"
could be put in the git config of that repository. Sure we will get it wrong once in a
while but it might be an alternative.
holger