On Wed, Apr 06, 2016 at 09:26:57PM +0200, Holger Freyther wrote: It's completely unnecessary, I only added logging for it. Before, it printed a notification for "32777", and we surely want to know what that's supposed to mean. We could add a conditional define like #ifndef SCTP_SENDER_DRY_EVENT #define SCTP_SENDER_DRY_EVENT ((1<<15)+9) #endif because sctp.h defines the value both as enum *and* as a #define: enum sctp_sn_type { SCTP_SN_TYPE_BASE = (1<<15), SCTP_ASSOC_CHANGE, #define SCTP_ASSOC_CHANGE SCTP_ASSOC_CHANGE SCTP_PEER_ADDR_CHANGE, #define SCTP_PEER_ADDR_CHANGE SCTP_PEER_ADDR_CHANGE SCTP_SEND_FAILED, #define SCTP_SEND_FAILED SCTP_SEND_FAILED SCTP_REMOTE_ERROR, #define SCTP_REMOTE_ERROR SCTP_REMOTE_ERROR SCTP_SHUTDOWN_EVENT, #define SCTP_SHUTDOWN_EVENT SCTP_SHUTDOWN_EVENT SCTP_PARTIAL_DELIVERY_EVENT, #define SCTP_PARTIAL_DELIVERY_EVENT SCTP_PARTIAL_DELIVERY_EVENT SCTP_ADAPTATION_INDICATION, #define SCTP_ADAPTATION_INDICATION SCTP_ADAPTATION_INDICATION SCTP_AUTHENTICATION_INDICATION, #define SCTP_AUTHENTICATION_INDICATION SCTP_AUTHENTICATION_INDICATION SCTP_SENDER_DRY_EVENT, #define SCTP_SENDER_DRY_EVENT SCTP_SENDER_DRY_EVENT }; Not sure though whether we should rely on this. I could also hardcode 32777, but that's not such a good idea either. Last resort is to not log the event and hope that all of us know what 32777 is all about. ~Neels

the coverity upload is now broken for a week... it is more than time to fix it! holger