hi,
this patch fixes the IMMIDIATE ASSIGNMENT REJECT message of OpenBSC. it is tested and works.
regards,
andreas
On Thu, Feb 07, 2013 at 11:58:14AM +0100, jolly wrote:
this patch fixes the IMMIDIATE ASSIGNMENT REJECT message of OpenBSC. it is tested and works.
what and how was it tested? But yes, it is pretty obvious that the reject is message was wrong. thanks for spotting it.
A default T3122 timer value of 10 is defined by default now. If set to 0, the reject message will not be sent. Note that when using existing configs with T3122 value set to 0.
What I have done in the past is to update the example configuration files. Could you please do that?
Holger Hans Peter Freyther wrote:
what and how was it tested? But yes, it is pretty obvious that the reject is message was wrong. thanks for spotting it.
i used a bts with only one singe timeslot for BCCH+SDCCH4 :) i tried to make a call and the phone got a reject, so it waits 10 seconds (as defined in my local config) until it tried again. (as the specs say)
What I have done in the past is to update the example configuration files. Could you please do that?
i checked the only example configuration file in osmo-nitb directory. it does not have t3122 defined, so the default value of 10 is used. i would suggest to remove default values from configuration files anyway, so a fix of a default value must not be done to the configuration file too.
On Thu, Feb 07, 2013 at 04:32:54PM +0100, jolly wrote:
i checked the only example configuration file in osmo-nitb directory. it does not have t3122 defined, so the default value of 10 is used. i would suggest to remove default values from configuration files anyway, so a fix of a default value must not be done to the configuration file too.
that is a good idea, please go ahead. I had the same issue when introducing the timeout for the SACCH deactivation/release indication.
Hi Jolly,
On Thu, Feb 07, 2013 at 11:58:14AM +0100, jolly wrote:
this patch fixes the IMMIDIATE ASSIGNMENT REJECT message of OpenBSC. it is tested and works.
thaks, I've merged it now that there was no issue about the timer / default configuration files anymore.
-
Harald Welte -
Holger Hans Peter Freyther -
jolly