I successfully tested some new patches on the AoIP branch locally and pushed them to the openbsc.git/aoip branch. They allow using 3G with AoIP.
@pespin: if aoip tester runs fail now, that's probably the cause.
@pmaier: I tried to apply all patches found on the pmaier/aoip branch, but excluded the commits started with "MSC side reset" because of build failure. The failure is the same I saw a few days ago, still unchanged:
CCLD osmo-bsc_nat ../../src/libcommon/libcommon.a(common_vty.o): In function `bsc_vty_go_parent': /n/s/osmo/git/openbsc/openbsc/build-3G/src/libcommon/../../../src/libcommon/common_vty.c:130: undefined reference to `osmo_ss7_vty_go_parent' ../../src/libcommon/libcommon.a(common_vty.o): In function `bsc_vty_is_config_node': /n/s/osmo/git/openbsc/openbsc/build-3G/src/libcommon/../../../src/libcommon/common_vty.c:140: undefined reference to `osmo_ss7_is_config_node' collect2: error: ld returned 1 exit status
I suspect you still have some of your work not pushed to libosmo-sccp? I can't find a private branch or patches on gerrit about osmo_ss7_vty.
In general I think it would be good to always keep your work on a private branch and push it frequently (doing anything you like on it, amending and so forth). For collaboration, but also to have a backup of your patches...?
If you like, we can have a call soon to figure out a rebase of your work onto aoip. A merge conflict is solved on the neels/pmaier_aoip branch ('git fetch' first), but I get above build failure.
~N
Hello Neels,
I suspect you still have some of your work not pushed to libosmo-sccp?
This looks to me like a linker problem. The two functions are a normal part of libosmo-sccp vty. I had to change the vty code in libcommon so that the VTY can traverse the nodes correctly again. This must be the top commit of my branch. I think you can just leave it out: wip: vty: make msc sccp addressesconfigurable
I wonder why it is building fine for me. Maybe libcommon lacks a $(LIBOSMOSIGTRAN_LIBS) in the LADD section?
regards. Philipp
On Wed, Jun 28, 2017 at 10:07:04AM +0200, Philipp Maier wrote:
I wonder why it is building fine for me. Maybe libcommon lacks a $(LIBOSMOSIGTRAN_LIBS) in the LADD section?
libraries don't have an LDADD section :)
Ah now I remember that we talked about this before, sorry for the noise.
It's clear now: I build with --enable-nat, hence the osmo-bsc_nat binary is built. You're probably not building it and hence don't see that this program lacks the sigtran LDADD. I should have noticed that before. Adding it.
~N
On 28/06/17 01:58, Neels Hofmeyr wrote:
I successfully tested some new patches on the AoIP branch locally and pushed them to the openbsc.git/aoip branch. They allow using 3G with AoIP.
@pespin: if aoip tester runs fail now, that's probably the cause.
Hi, this morning I enabled again the osmo-gsm-tester_run job and seems to be working fine: http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_... (and 1002).
-
Neels Hofmeyr -
Pau Espin Pedrol -
Philipp Maier