To fix the osmo-msc preliminary debian package build of osmo-msc, I need these patches in osmo-mgw to be merged:
https://gerrit.osmocom.org/3999 https://gerrit.osmocom.org/4000 https://gerrit.osmocom.org/4001 https://gerrit.osmocom.org/4002 https://gerrit.osmocom.org/4003 https://gerrit.osmocom.org/4005
(topic 'new_mgw' less 4006 and 4007)
If review takes too long I am tempted to just merge it ahead to fix the state of osmo-msc.deb in https://build.opensuse.org/project/show/network:osmocom:nitb-split:nightly
If I do, it means that I would like to fix and improve those patches later, not that I want to smuggle them past review. I just want to finally get the debian builds working and off my mind again.
The osmo-msc currently fails because it needs a header file not included in libosmo-mgcp-client-dev, because that is still tied to libosmo-mgcp headers, which are of course not included in the libosmo-mgcp-client deb. I want them to be separated completely to save us this kind of cumbersomeness in the future. Only one of the above commits unties libosmo-mgcp-client from the other libs, but small bits here and there make the change depend on the others in that bunch. I could re-arrange, but that would take time. I'd rather just keep them in that order, we want them merged anyway.
The large ones in the middle are dexter's work on the next generation MGW that happened on a branch, being placed beside the legacy code. This way we can move from legacy to new code in osmo-msc and osmo-bsc independently.
~N
Hi Neels,
On Thu, Sep 21, 2017 at 12:48:28AM +0200, Neels Hofmeyr wrote:
To fix the osmo-msc preliminary debian package build of osmo-msc, I need these patches in osmo-mgw to be merged:
I'm surprised about this. Why would an entirely new osmo-mgw implementation be needed to build debian packages, if that implementation is not yet reviewed and not yet used from either osmo-bsc or osmo-msc master?
If review takes too long I am tempted to just merge it ahead to fix the state of osmo-msc.deb in https://build.opensuse.org/project/show/network:osmocom:nitb-split:nightly
Please don't. I've just spent a long time and have lots of review comments on 4003 alone. There's nothing wrong at all with the work being done so far, to the contrary. I just think it is not ready yet. In fact, it has never gone through any review, and your commit above has been the first time this went into gerrit at all.
If I do, it means that I would like to fix and improve those patches later, not that I want to smuggle them past review. I just want to finally get the debian builds working and off my mind again.
I don't think debian package builds should depend on significant new code that is not in master yet.
The osmo-msc currently fails because it needs a header file not included in libosmo-mgcp-client-dev, because that is still tied to libosmo-mgcp headers, which are of course not included in the libosmo-mgcp-client deb. I want them to be separated completely to save us this kind of cumbersomeness in the future.
I'm not following.
Only one of the above commits unties libosmo-mgcp-client from the other libs, but small bits here and there make the change depend on the others in that bunch. I could re-arrange, but that would take time. I'd rather just keep them in that order, we want them merged anyway.
The design/architecture of the new osmo-mgw needs to be done right before we merge it. Related code has not been subject to review so far, and I think it will still take quite a bit. There's no point in rushing this now, then make osmo-{bsc,msc} use that and then do another iteration of changes which will very likely affeect the protocol and thus interoperability with osmo-{bsc,msc}.
I'm all in favor of efficiency and not spending time on re-arranging patches. The question to me is rather why were the untangling patches developed based on a non-master branch of very large ongoing development work, rather than on master? AFAICT, this is the reason we now need to spend extra time to re-order the patches.
Regards, Harald
On Thu, Sep 21, 2017 at 12:49:13PM +0800, Harald Welte wrote:
I'm surprised about this. Why would an entirely new osmo-mgw implementation be needed to build debian packages, if that implementation is not yet reviewed and not yet used from either osmo-bsc or osmo-msc master?
We can strip the addition of debian packages for later, if that's better.
If review takes too long I am tempted to just merge it ahead to fix the state of osmo-msc.deb in https://build.opensuse.org/project/show/network:osmocom:nitb-split:nightly
Please don't. I've just spent a long time and have lots of review
ack
In fact, it has never gone through any review, and your commit above has been the first time this went into gerrit at all.
It's hopefully the last of the series of code bomb developments we faced this year. I'm looking forward to normal gerrit patch submissions from then on.
The osmo-msc currently fails because it needs a header file not included in libosmo-mgcp-client-dev, because that is still tied to libosmo-mgcp headers, which are of course not included in the libosmo-mgcp-client deb. I want them to be separated completely to save us this kind of cumbersomeness in the future.
I'm not following.
The split off libosmo-mgcp-client still used headers from libosmo-legacy-mgcp. After a 'make install', all of them are present, but from just a -client deb package, they aren't.
I prefer to avoid this kind of interdependency, reminding me of gsm_data_shared.h.
There still is one header file of shared code, but I want each library to have its own copy of it. To avoid code dup, I want that copy to be made at 'make'-time -- ok because it's within the same git repository.
That is the main reason why I was waiting for the new version of libosmo-mgcp-client to fix the osmo-msc deb package. This shared header needs to be part of the deb.
After reading this, I will fix the osmo-msc.deb beforehand. I will copy the shared header over, and put the sharing thereof in place after the new mgw has been merged. We can then also discuss that part later.
why were the untangling patches developed based on a non-master branch of very large ongoing development work, rather than on master?
I assumed we would go through it more quickly, maybe a misconception.
~N
On Thu, Sep 21, 2017 at 12:49:13PM +0800, Harald Welte wrote:
I'm all in favor of efficiency and not spending time on re-arranging patches.
I have now re-arranged patches and kindly request review of only https://gerrit.osmocom.org/4010 which is my favorite way of fixing the libosmo-mgcp-client-dev.deb
The result should be that osmo-msc.deb will finally build successfully again, because libosmo-mgcp-client-dev is fixed to not need headers it doesn't install.
4010 will cause minor conflicts with the large 4003 in review, which I have solved, but am keeping on branch neels/new_mgw and not pushing to gerrit yet, to wait for dexter and not get in his way there. Once his next patch set is ready (he should for convenience stay on the current master and not rebase onto 4010), I will consolidate with 4010 and rebase+solve 4003 so that all matches up again.
Thanks!
~N
-
Harald Welte -
Neels Hofmeyr