Hi Thomas,
What is the reason you disabled setting power attenuation an receive gain for the second trx? Since both channels in UmTRX are independent, it should be possible to control tx power and rx gain independently.
In the "SETPOWER" command handler: if (mPrimary) mRadioInterface->setPowerAttenuation(dbPwr);
In the "SETRXGAIN" it's even stranger, as it's set twice in case of primary trx: newGain = mRadioInterface->setRxGain(newGain); mEnergyThreshold = INIT_ENERGY_THRSHD; if (mPrimary) newGain = mRadioInterface->setRxGain(newGain);
-- Regards, Alexander Chemeris. CEO, Fairwaves LLC / ООО УмРадио http://fairwaves.ru
On Sat, Jul 13, 2013 at 5:45 PM, Alexander Chemeris alexander.chemeris@gmail.com wrote:
What is the reason you disabled setting power attenuation an receive gain for the second trx? Since both channels in UmTRX are independent, it should be possible to control tx power and rx gain independently.
In the "SETPOWER" command handler: if (mPrimary) mRadioInterface->setPowerAttenuation(dbPwr);
The control interface was setup for OpenBTS, which does not make a distinction between independent channel gain. So I locked both gain settings to the primary channel (the one that initializes the device).
For better osmo-bts usage, I split the gain settings in the same way that we discussed for the tuning setting. Note that this breaks OpenBTS usage, but that fix should really be in core and not the transceiver.
git://github.com/ttsou/openbts-p2.8.git umtrx_dual_test
In the "SETRXGAIN" it's even stranger, as it's set twice in case of primary trx: newGain = mRadioInterface->setRxGain(newGain); mEnergyThreshold = INIT_ENERGY_THRSHD; if (mPrimary) newGain = mRadioInterface->setRxGain(newGain);
Very strange indeed. That's a bug. Fixed in the same patch.
Thomas
On Sat, Jul 13, 2013 at 8:39 PM, Thomas Tsou ttsou@vt.edu wrote:
On Sat, Jul 13, 2013 at 5:45 PM, Alexander Chemeris alexander.chemeris@gmail.com wrote:
What is the reason you disabled setting power attenuation an receive gain for the second trx? Since both channels in UmTRX are independent, it should be possible to control tx power and rx gain independently.
In the "SETPOWER" command handler: if (mPrimary) mRadioInterface->setPowerAttenuation(dbPwr);
The control interface was setup for OpenBTS, which does not make a distinction between independent channel gain. So I locked both gain settings to the primary channel (the one that initializes the device).
For better osmo-bts usage, I split the gain settings in the same way that we discussed for the tuning setting. Note that this breaks OpenBTS usage, but that fix should really be in core and not the transceiver.
git://github.com/ttsou/openbts-p2.8.git umtrx_dual_test
Well, since we don't control the core of OpenBTS, could we make the transceiver compatible with both ways?
Also setting the Tx/Rx gains is a proper way for Multi-ARFCN version where ARFCN are actually on the same TRX. So we have to make this compatible with both ways anyway. E.g. we could introduce a new command to configure transceiver regarding TRXs.
-- Regards, Alexander Chemeris. CEO, Fairwaves LLC / ООО УмРадио http://fairwaves.ru
On Sat, Jul 13, 2013 at 7:43 PM, Alexander Chemeris alexander.chemeris@gmail.com wrote:
On Sat, Jul 13, 2013 at 8:39 PM, Thomas Tsou ttsou@vt.edu wrote:
For better osmo-bts usage, I split the gain settings in the same way that we discussed for the tuning setting. Note that this breaks OpenBTS usage, but that fix should really be in core and not the transceiver.
git://github.com/ttsou/openbts-p2.8.git umtrx_dual_test
Well, since we don't control the core of OpenBTS, could we make the transceiver compatible with both ways?
We would need to change the gain control interface or set something at compile time. Basically, right now there is no way for the transceiver to distinguish between a set-all-gains and set-channel-gain request.
Also setting the Tx/Rx gains is a proper way for Multi-ARFCN version where ARFCN are actually on the same TRX. So we have to make this compatible with both ways anyway. E.g. we could introduce a new command to configure transceiver regarding TRXs.
Assuming OpenBTS core cannot be touched, we can either add a new set-channal-gain command or a second boolean argument on the existing SETRXGAIN command. For the latter case, OpenBTS would ignore the second argument.
Thomas
On Sat, Jul 13, 2013 at 10:05 PM, Thomas Tsou tom@tsou.cc wrote:
On Sat, Jul 13, 2013 at 7:43 PM, Alexander Chemeris alexander.chemeris@gmail.com wrote:
On Sat, Jul 13, 2013 at 8:39 PM, Thomas Tsou ttsou@vt.edu wrote: Also setting the Tx/Rx gains is a proper way for Multi-ARFCN version where ARFCN are actually on the same TRX. So we have to make this compatible with both ways anyway. E.g. we could introduce a new command to configure transceiver regarding TRXs.
Assuming OpenBTS core cannot be touched, we can either add a new set-channal-gain command or a second boolean argument on the existing SETRXGAIN command. For the latter case, OpenBTS would ignore the second argument.
Yes, that's the best way imho.
-- Regards, Alexander Chemeris. CEO, Fairwaves LLC / ООО УмРадио http://fairwaves.ru
-
Alexander Chemeris -
Thomas Tsou -
Thomas Tsou