Hi,
you may be aware that the '#include "config.h"' in libasn1c's asn_system.h breaks builds with the out-of-the-box 'make install'. So far we go to the installed header and remove that line.
This time I've removed the line from the source tree before building, and I can't find any effect really. My source tree has no config.h file to begin with.
But I'm not sure what would be a point of failure there. When I commit this, will I break something I merely happen to not be using? Any autoconf guru here that could resolve this with a quick glance?
http://git.osmocom.org/libasn1c/tree/configure.ac http://git.osmocom.org/libasn1c/tree/include/asn1c/asn_system.h
Thanks, ~Neels
If no-one knows any better I'll just commit it and wait for complaints, if any.
~Neels
On Tue, Feb 16, 2016 at 01:07:15PM +0100, Neels Hofmeyr wrote:
Hi,
you may be aware that the '#include "config.h"' in libasn1c's asn_system.h breaks builds with the out-of-the-box 'make install'. So far we go to the installed header and remove that line.
This time I've removed the line from the source tree before building, and I can't find any effect really. My source tree has no config.h file to begin with.
But I'm not sure what would be a point of failure there. When I commit this, will I break something I merely happen to not be using? Any autoconf guru here that could resolve this with a quick glance?
http://git.osmocom.org/libasn1c/tree/configure.ac http://git.osmocom.org/libasn1c/tree/include/asn1c/asn_system.h
Thanks, ~Neels
--
- Neels Hofmeyr nhofmeyr@sysmocom.de http://www.sysmocom.de/
=======================================================================
- sysmocom - systems for mobile communications GmbH
- Alt-Moabit 93
- 10559 Berlin, Germany
- Sitz / Registered office: Berlin, HRB 134158 B
- Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte
On 17 Feb 2016, at 11:51, Neels Hofmeyr nhofmeyr@sysmocom.de wrote:
If no-one knows any better I'll just commit it and wait for complaints, if any.
nothing in the header should depend on config.h, what we don't know is what depends on an indirect include. Anyway. I believe a public header should not include config.h.
holger