Sipos Csaba wrote:

This is the final patch for Hungary specific settings for the osmocom-analog project.

Tested against a locked Motorola MCR4800XL, it works on all channels and TAs.

Please let me know if any more work needs to be done.

Regards, Csaba

Hi Csaba,

thank your for your patch! Can you review it for a moment?

You stated that "All TA combinations were tested (1-15)." in your previous messages. Your patch only includes the range 1-9:

+ { 450, 1, 6, 1,9, "HU", "Hungary", "WESTEL 0660", frq_450_hu },

Also the channel 132 appears twice:

+ { 132,239, 467.370, -0.020, 0.8, 10.0, 0 }, + { 1, 132, 469.990, -0.020, 0.8, 10.0, 0 },

For the first line it is 467.370 MHz For the second line I calculated 467.370 MHz too. Both channels have the same frequency. Why not combine them as "{ 1, 239, 469.990, -0.020, 0.8, 10.0, 0 },". Is there some gap? Do I miss something?

Best regards,

Andreas