From: Álvaro Neira Ayuso anayuso@sysmocom.de
In the case that we use sysmobts_get_nominal_power inside the l1_if we receive a warning for forgive include that header.
Signed-off-by: Alvaro Neira Ayuso anayuso@sysmocom.de --- src/osmo-bts-sysmo/l1_if.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index 79d506a..6834240 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -60,6 +60,7 @@ #include "hw_misc.h" #include "misc/sysmobts_par.h" #include "eeprom.h" +#include "utils.h"
extern int pcu_direct;
On Tue, May 13, 2014 at 05:14:38PM +0200, Alvaro Neira Ayuso wrote:
Good Morning,
In the case that we use sysmobts_get_nominal_power inside the l1_if we receive a warning for forgive include that header.
Please try again. "forgive" is certainly not the right word here. Be more explicit with the "in the case". It applies to sysmobts-v2 and all versions above 2.2.0.
Include the warning generated by the compiler in the commit message as well. E.g. look at 666fec7ff23e125730d7e13aa6d68112cde082de for an example.
cheers holger
From: Álvaro Neira Ayuso anayuso@sysmocom.de
In sysmocom-v2 and all versions above 2.2.0, when we use sysmobts_get_nominal_power for calculating the power transmitter inside the l1_if, we receive a warning for forgot include that header.
l1_if.c: In function 'l1if_activate_rf': l1_if.c:1144:6: warning: implicit declaration of function 'sysmobts_get_nominal_power' [-Wimplicit-function-declaration]
Signed-off-by: Alvaro Neira Ayuso anayuso@sysmocom.de --- src/osmo-bts-sysmo/l1_if.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/src/osmo-bts-sysmo/l1_if.c b/src/osmo-bts-sysmo/l1_if.c index 79d506a..6834240 100644 --- a/src/osmo-bts-sysmo/l1_if.c +++ b/src/osmo-bts-sysmo/l1_if.c @@ -60,6 +60,7 @@ #include "hw_misc.h" #include "misc/sysmobts_par.h" #include "eeprom.h" +#include "utils.h"
extern int pcu_direct;
-
Alvaro Neira Ayuso -
Holger Hans Peter Freyther