Hi Folks,
At present endpoint IDs are assumed to end with @mgw when trying to find/match non-e1 endpoint ids. Unless the MGCP peer supports compatible configuration, DNS or a hosts file may need to be setup to meet the hardwired host name requirement in the openBsc MGCP, and then we can still only run one BSC.
The attached patch makes a simple change to use either the configured local_ip or source_addr, matching logic used in SDP responses. It also improves the error message when an endpoint can't be found.
Please consider for inclusion to mainline.
Kind Regards,
Mike
On 28 Aug 2015, at 17:12, Mike McTernan (wavemobile) mike.mcternan@wavemobile.com wrote:
Hi Folks,
At present endpoint IDs are assumed to end with @mgw when trying to find/match non-e1 endpoint ids. Unless the MGCP peer supports compatible configuration, DNS or a hosts file may need to be setup to meet the hardwired host name requirement in the openBsc MGCP, and then we can still only run one BSC.
The attached patch makes a simple change to use either the configured local_ip or source_addr, matching logic used in SDP responses. It also improves the error message when an endpoint can’t be found.
the cellmgr-ng had a more complete object model (vtrunks, e1 id..) but what about simplifying the code and just checking for the ‘@‘? If somebody addresses us. E.g. the hostname on the existing deployments is not ‘mgw’ and unless I am missing something neither cfg->local_ip nor cfg->source_addr hold “mgw” as name?
Any reason not to remove the hostname check?
holger
On 28 Aug 2015, at 18:16, Mike McTernan (wavemobile) mike.mcternan@wavemobile.com wrote:
None that I can think of.
great, do you have time to prepare a revised patch?
holger