Hi,
Coverity pointed out a missing break. I have added it now but the fix might break BS11 code that relied on this broken functionality.
Could anyone with a BS11 please test this? I will integrate the change in a week.
holger
Holger Hans Peter Freyther wrote:
Coverity pointed out a missing break. I have added it now but the fix might break BS11 code that relied on this broken functionality.
Could anyone with a BS11 please test this? I will integrate the change in a week.
hi,
if noone else has a working setup, i could test it. is this patch already submitted (to master)? if this patch breaks functionality, what malfunction would i expect?
andreas
Holger Hans Peter Freyther wrote:
Coverity pointed out a missing break. I have added it now but the fix might break BS11 code that relied on this broken functionality.
Could anyone with a BS11 please test this? I will integrate the change in a week.
hi holger,
tests showed: the "break" statement does not break the functionality. during normal operation, this point of code is not reached. i had to remove TX antenna to generate an alarm, so the "break" statement was reached. bs11 worked fine after restoring antenna.
regards,
andreas
-
Andreas Eversberg -
Holger Hans Peter Freyther -
Nick Khamis