Re: libosmo-abis question

Hi Max,

On Tue, Sep 20, 2016 at 12:01:57PM +0200, Max wrote:

rs->rtp_bfd.when = rs->rtcp_bfd.when = BSC_FD_READ;
rs->rtp_bfd.when = rs->rtcp_bfd.when = 0;

It's on the border between 2 commits so it's likely merge artifact. Which value is the right one? Or should it be rtcp_bfd?

I think both BSC_FD_READ as well as 0 should work, see the comment in osmo_rtcp_fd_cb().

So either the RTCP data will be read/received inside rtp_session_recvm_with_ts() (rtcp_bfd.when == 0), or it will be explicitly processed by the call to rtp_session_rtcp_recv() from osmo_rtcp_fd_cb() in the rtcp_bfd.when == BSC_FD_READ case.

The explicit call might be the better/nicer way, so I'd go for BSC_FD_READ, unless we experience problems with that.