From Harald Welte <laforge(a)gnumonks.org>rg>:
Harald Welte has posted comments on this change.
Change subject: Fix DTX indicator in SI
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/40/1/openbsc/src/libbsc/system_information.c
File openbsc/src/libbsc/system_information.c:
Line 722: if (bts->network->dtx_enabled)
slightly unrelated to this patch, bu still worth addressing in a separate fix: The DTX
configuration should be per BTS and not a global, network-wide setting. There might be a
network-wide default with BTS-local overrides, but that probably gets too complex to
understand?
--
To view, visit
https://gerrit.osmocom.org/40
To unsubscribe, visit
https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d55168475ad47044b6238b55846ea22bdd518a4
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev(a)sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge(a)gnumonks.org>
Gerrit-HasComments: Yes