On Sun, Mar 27, 2016 at 10:53:53AM +0200, Harald Welte wrote:
Hi Neels,
On Sat, Mar 26, 2016 at 09:35:33PM +0100, Neels Hofmeyr wrote:
+static inline const char *auth_action_str(enum auth_action a)
we normally try to avoid introducing some custom value/string converter code like this and use 'struct value_string' for this.
ah :) (sorry for the noise from previous mail)
+#define AUTH_CASE(X) \
- case X: return #X
you can also define a macro like this that generates a { X, #X }, for struct value_string
- case -1:
return "(internal error)";this would be an ugly
{ -1, "(internal error") }
which is soon replaced by your #define AUTH_ERROR anyway.
yes, I preferred to first have the test suite in place before introducing more enum values...
... and please refrain from having non-trivial functions (or data definitions), and particularly non-performance-critical functions like this inline in a header file.
ack
I would merge the entire patch-set, if you could address that one issue. Thanks!
great, am onto it!
~Neels