Re: [PATCH 3/3] rsl: Implement handling of rsl Delete Ind message

Hi Jacob,

There are two reasons, why I use == GSM48_MT_RR_IMM_ASS: - currently IMM.ASS.EXT messages are not used in openbsc - this code can handle only IMM.ASS messages, because IMM.ASS.EXT message allocates two channels and we should release these two channels in this case.

2014-02-20 13:24 GMT+04:00 Jacob Erlbeck jerlbeck@sysmocom.de:

On 20.02.2014 08:28, Ivan Kluchnikov wrote:

...

If bsc receives Delete_Ind message from bts, bsc should release allocated channel, which was specified in dropped imm_assign message. +/* CCCH is overloaded, IMM_ASSIGN was dropped */ +static int rsl_rx_delete_ind(struct gsm_bts_trx *trx, struct msgb *msg) +{

[...]

...

• if (ia->msg_type == GSM48_MT_RR_IMM_ASS) {
  

Why are you not checking again != GSM48_MT_RR_IMM_ASS_REJ? What's with the IMM.ASS.EXT messages?

Jacob