Re: 7bit changes to libosmocore

Hi Holger and Andreas, On Sun, Jul 07, 2013 at 06:37:57PM +0200, Holger Hans Peter Freyther wrote: We can establish: * Andreas should have run 'make check' before asking me to merge * I should have run 'make check' ahead of the commit and not immediately after ;) My apologies for that. * I should have done more careful review of the 7bit changes * merge requests should not go in private mail but on the list, giving the entire team the ability to review before it is merged. So as a result, we introduce a new rule / process: * merge requests will go through the public mailing list, with the complete patch-set posted via git-send-email and an explicit statement that this is a request for review+merge. Let's try this for some time and see if we can avoid to cause this problem again. And in general, please try to keep a constructive atmosphere on the list, even under conditions of stress. Nobody here _intentionally_ wants to waste time of others. We have to work together on this, the Osmocom community is small enough that we cannot afford to loose any of you due to frustration. Regards, Harald -- - Harald Welte <laforge(a)gnumonks.org> http://laforge.gnumonks.org/ ============================================================================ "Privacy in residential applications is a desirable marketing option." (ETSI EN 300 175-7 Ch. A6)