It seems like there's bunch of corner cases in CTRL protocol due underspecification. Would it make sense to formally specify it in smth like GNU bison and generate parsers automatically instead of relying on manual parsing?
This would probably allow us to automatically generate docs for it as well.
On 03.10.2017 02:49, Harald Welte wrote:
Opinions?
Should we further restrict the CTRL interface strings (and those of systems exporting to CTRL) to standard US 7-bit ASCII with a limited set of special characters such as ":-_@" but prevent any non-printable chars or special chars like "{|}()~[]^`'?<>=;/+*&%$#!"? I would support such a motion. We could even make it more general and use that for all our identifier strings and have a general validation function that all code modules call whenever validating a string identifier used, such as e.g. osmo_fsm names, etc.