31 May
2016
31 May
'16
2 p.m.
Patch Set 1:
It looked to me like the code wants to make sure not to change the llme->kc by passing
it into the function.
So it wants to copy to a local buffer and pass *its* address instead.
If we'd want to keep it that way then, yes, I see now and agree about the size, and we
should use a malloc(gprs_cipher_key_length(..))
...or just pass &kc directly.
I'm not sure how to decide, just caught this by accident and am not familiar with this
code...
--
To view, visit https://gerrit.osmocom.org/128
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f1b7454a0de5b7f4734aca4d03dbe67db5de189
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger(a)freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr(a)sysmocom.de>
Gerrit-HasComments: No