Re: [PATCH 1/4] ussd: Send USSD on call setup on MSC errors

On Wed, Sep 11, 2013 at 10:46:55AM +0200, Jacob Erlbeck wrote:

Good Evening,

these patches look fine! The only things I have is coding style. I understand that it takes some time to get used to it.

• if (! text)

no space

• if (! msg || msgb_l3len(msg) < sizeof(*gh)) {

• return;
  

• }

nu curly braces for single instructions, no space

• bsc_send_ussd_notification(conn, msg, conn->bts->network->bsc_data->ussd_no_msc_txt);
  

Maybe we should start to save the bsc_data in the subscriber connection as well?

• if (ret != BSC_CON_SUCCESS) {

• /* allocation has failed */
  

• if (ret == BSC_CON_REJECT_NO_LINK) {
  

• 	bsc_send_ussd_notification(conn, msg, msc->ussd_msc_lost_txt);
  

• } else if (ret == BSC_CON_REJECT_RF_GRACE) {
  

• 	bsc_send_ussd_notification(conn, msg, msc->ussd_grace_txt);
  

• }
  

no curly braces.

• if (!msc || !msc->msc_con->is_authenticated) {

• // VSAT link down
  

left over of debug changes/information leak.

I will try to fix these warnings right now. You will not need to send another round of patches.