Re: [PATCH 1/3] smpp_smsc: Print errno and close socket if read returns -1

On Fri, 2014-01-17 at 18:23, Holger Hans Peter Freyther wrote:

On Fri, Jan 17, 2014 at 05:26:26PM +0100, Daniel Willmann wrote:

For reference. you should make the errno check in both cases or just simplify the reading part and move the error handling to a macro.

Good catch, thanks. I made the checks into a macro which should eventually end up in libosmocore so it's usable by other projects as well.

I found another issue as well which I rolled into my last patch. msgb_alloc takes a uint16_t as size so the check was still wrong.

I rebased and pushed the new patches to daniel/smpp-fixes

Regards, Daniel