14 May
2016
14 May
'16
12:21 p.m.
From Holger Freyther holger@freyther.de:
Holger Freyther has posted comments on this change.
Change subject: Change internal API for consistency ......................................................................
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/59/1//COMMIT_MSG Commit Message:
Line 7: Change internal API for consistency consistency with what?
https://gerrit.osmocom.org/#/c/59/1/src/osmo-bts-sysmo/sysmo_l1_if.h File src/osmo-bts-sysmo/sysmo_l1_if.h:
Line 41: uint8_t trx; We have a TRX object. Can you call it trx_no?
--
To view, visit https://gerrit.osmocom.org/59
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic584611184b0c8b5417ecff0ddae3d526b55a079
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max msuraev@sysmocom.de
Gerrit-Reviewer: Holger Freyther holger@freyther.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes