22 Apr
2016
22 Apr
'16
2:23 p.m.
Hi,
I subscribed myself to more change notifications on another gerrit to see how the coments
would look like. there is not a lot o context but at least some.
Begin forwarded message:
Jesus Fernandez has posted comments on this change.
Change subject: Possible crash in QMakeSourceFileInfo
......................................................................
Patch Set 7:
(6 comments)
Thank you
....................................................
File qmake/generators/makefiledeps.cpp
Line 606
It's really weird, but you're right.
Dropped... I mean Done.
Line 648
Done
Line 655
Done
Line 667
Done
Line 592: for (x += 1 ; x + inc_len < buffer_len
&& buffer[x + inc_len] != '<';
And an extra whitespace :)
Done!
Line 639: for (x += 1; x + inc_len < buffer_len &&
buffer[x + inc_len] != '<';
Done