Hi Alexander,
On Tue, Sep 06, 2011 at 12:21:56AM +0200, Alexander Huemer wrote:
On Mon, Sep 05, 2011 at 11:00:13AM +0200, Harald Welte wrote:
So unless there is a really compelling reason to change, I would want to have it stay like it is.
There is surely no compelling reason to do changes like these. My idea was just to add some structure to the include directory +
- it was cheap
- I didn't expect much trouble from the change
I have more ideas like this, e.g.:
- declaring _all_ defined functions (cproto [1] makes that easy and works quite well)
I'm not sure if that really is good. Some of our 'undeclared functions' are more or less intentional and serve as a reminder that something still has to be cleaned up, i.e. the interface is not as clean as it should be.
- sorting #include statements in groups were applicable (like in opensolaris code)
Not sure if that makes that much sense either.
What I'd appreciate more is patches
* towards completing the recently-introduced doxygen API reference. * first aim for covering all exportet functions of all libraries in a short way * secondly, expand the documentation by making it more verbose * finally, start documenting internal interfaces inside openbsc, osmo-bts, osmocomBB, etc. * introducing EXPORT_SYMBOL() to hide library-internal symbols from applications
Regards, Harald