11 May
2016
11 May
'16
8:27 p.m.
From Harald Welte laforge@gnumonks.org:
Harald Welte has posted comments on this change.
Change subject: Move DTX settings to BTS ......................................................................
Patch Set 3: Code-Review-1 Verified-1
(1 comment)
https://gerrit.osmocom.org/#/c/40/3/openbsc/doc/examples/osmo-bsc/osmo-bsc.c... File openbsc/doc/examples/osmo-bsc/osmo-bsc.cfg:
Line 57: dtxu force I would prefer something more hierarchical like
dtx uplink force dtx downlink
And of course the respetive "no dtx ..." commands need to exist for disablign the feature.
Also, why only change osmo-bsc.cfg? What about all the other config file examples in the tree that have 'dtx-used 0'? They would all fail to start.
--
To view, visit https://gerrit.osmocom.org/40
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d55168475ad47044b6238b55846ea22bdd518a4
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max msuraev@sysmocom.de
Gerrit-Reviewer: Harald Welte laforge@gnumonks.org
Gerrit-Reviewer: Max msuraev@sysmocom.de
Gerrit-HasComments: Yes