11 Nov
2015
11 Nov
'15
4:23 p.m.
----- Original Message -----
Nice, thanks. Please note, this is not something that blocks Fedora
review, I just wanted to point it out, e.g. to consider it for
next API update sometimes in the future
thanks & regards
Jaroslav
Hi Jaroslav,
On Tue, Nov 10, 2015 at 04:56:23AM -0500, Jaroslav Skarvada wrote:
Patch attempting to fix it is attached.
I am working on getting libosmocom package into
Fedora, there is
review request in [1].
Thanks for this!
During the packaging I found following minor
issues:
- Incorrect FSF addresses in source code
This is easy to fix. Do you already have a patch to fix all
occurrences? I'd happily apply that.
- exit call in
the library: /usr/lib64/libosmovty.so.3.0.0 exit(a)GLIBC_2.2.5
libraries shouldn't generally call exit.
libosmovty started as a fork of the VTY (telnet command line interface)
code of GNU zebra. So the code was not written as a library to begin
with, but was part of zebra itself.
In any case, addressing those issues is not particularly easy, as said
functions should never fail at this point, but they don't have a way to
return an error code, or their callers simply assume they always
succeed.
So the best we can do without breaking API and ABI (and modifying all
users of the library) is to change the exit(1) calls into an assert.
Would that be better?