Re: [PATCH 1/2] write_queue: Avoid possible use-after-free if fd is read-/writable

On Wed, 2014-06-04 at 17:58, Holger Hans Peter Freyther wrote:

On Wed, May 21, 2014 at 03:08:18PM +0200, Daniel Willmann wrote:

...

return 0; +err_badfd:

• return rc;

hi, why do you want to change the return value here? Why is the return 0 not good enough here?

You're right, it would be. In fact, the return value of this callback is not checked in osmo_select_main() at all (and there doesn't seem to be any use for it in that place either). I'll update the patch to return 0 in both cases.

Regards, Daniel