26 Apr
2016
26 Apr
'16
1:28 p.m.
On Fri, Apr 22, 2016 at 02:41:12PM +0200, Sergey Kostanbaev wrote:
From: Sergey Kostanbaev
<Sergey.Kostanbaev(a)gmail.com>
---
src/gsm/gsm0480.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/src/gsm/gsm0480.c b/src/gsm/gsm0480.c
index 8963b78..55bddd5 100644
--- a/src/gsm/gsm0480.c
+++ b/src/gsm/gsm0480.c
@@ -248,12 +248,6 @@ int gsm0480_decode_ss_request(const struct gsm48_hdr *hdr, uint16_t
len,
struct ss_request *req)
{
int rc = 0;
-
- if (len < sizeof(*hdr) + 2) {
- LOGP(0, LOGL_DEBUG, "SS Request is too short.\n");
- return 0;
- }
-
if (gsm48_hdr_pdisc(hdr) == GSM48_PDISC_NC_SS) {
I believe this should only remove the "+ 2" and still check for
if (len < sizeof(*hdr)) {
return 0;
}
since the code continues to dereference hdr, or is this the explicit
responsibility of the caller?
~Neels
--
- Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte