Re: [PATCH] remove two compiler warnings for unused variables

On Tue, Apr 12, 2016 at 12:23:52AM +0200, Harald Welte wrote: It was me, not Max :) Maybe instead of numerous unused variables, we should have a single #warning then. Every warning hinders my dev cycle. For pretty much every compilation, I have to parse/browse the list of warnings, *all* the time. Even a #warning would stare me in the face for every build. There are a couple of those already. So I'd even prefer a TODO file in / , admitted that these kind of files tend to go outdated. Also, having warnings around makes it harder to spot new warnings I've introduced. I see some warnings scroll by, then assume they're just the old ones, or have to scroll around to check every time. I'd prefer a way that I don't have to check for and read the same old warnings dozens of times every day, while not having the time to investigate/fix anyway... I unnecessarily lose time on those. A workaround for me would be to eradicate the warnings on our iu branches but not commit them to master. ~Neels -- - Neels Hofmeyr <nhofmeyr(a)sysmocom.de> http://www.sysmocom.de/ ======================================================================= * sysmocom - systems for mobile communications GmbH * Alt-Moabit 93 * 10559 Berlin, Germany * Sitz / Registered office: Berlin, HRB 134158 B * Geschäftsführer / Managing Directors: Holger Freyther, Harald Welte