23 Mar
2016
23 Mar
'16
6:35 p.m.
On 23 Mar 2016, at 19:14, msuraev@sysmocom.de wrote:
From: Max msuraev@sysmocom.de
Consistently use enums instead of (u)int, char etc. Use bool for boolean types. Add extra debug output with channel mode and type to simplify troubleshooting.
Nack.
* You touch an external protocol that is versioned. Does the size of the structure change? Either way it needs to be in the commit messages.
* You are mixing "add debug messages" and "change types". There is no connection between these two logical changes and they should not be in the same commit.