Re: Patches - add support for mobile-originated USSD - D'oh!

Now with patch...

Harald Welte wrote:

Hi Mike,

On Tue, Oct 06, 2009 at 06:11:52PM +0100, Mike Haben wrote:

...

More patches - these two (combined) add support for mobile-originated USSD. The demonstration application, implemented in ussd.c, is that sending *#100# to the network will display your 5-digit extension. It's not 100% finished - I've tested it on 6 handsets, 5 of them work perfectly, but the 6th (Samsung i520) doesn't seem to receive the response, so more experimenting to be done...

thanks a lot.

some initial review comments

• please move the "#define GSM0480_" into the header file
• please pay attention to the coding style, we use linux-2.6/Documentation/CodingStyle . This particularly relates to having "do {" on one line and not using // style comments, and space at "if ("
• I don't like the ptr8[n] arrays. If there is a common/static header, please define a structure for it. For the variable parts at the end, things like msgb_tv_put() or msgb_tlv_put() should be used.

can you please take care of this and re-submit? thanks.