18 Oct
2012
18 Oct
'12
11:40 p.m.
On Thu, Oct 18, 2012 at 07:16:43PM +0200, Peter Stuge wrote:
Pablo Neira Ayuso wrote:
Never mind, I already pushed it including the break thing :-)
at the risk of being annoying, I think the patch
is good as is.
I don't want that this becomes a "bikeshed color" discussion [1],
I think the code changes are clear enough.
The patch is clear and a great improvement. The code in the file
*after patching* could be made more clear with only the minimal
changes I mentioned. Of course it is subjective what is clear and
not. :)
I'm happy to send a follow-up patch once you've plugged the leak!