3 Oct
2014
3 Oct
'14
8:41 a.m.
On Thu, Oct 02, 2014 at 11:09:07PM +0200, Jan Engelhardt wrote:
Good Morning Jan,
The link stage fails at some point.
libosmogsm.so:lapd-core.c uses
talloc_free, but does not link to libtalloc.so. Correct this.
my position has not changed. The --disable-talloc is an option for
Embedded Firmware (e.g. OsmocomBB) that do not want to include talloc.
It is not for people that want to use their distributions talloc.
Using the osmocom/core/talloc.h and linking against another/unknown
version of talloc is scraming for problems (API/ABI issues, etc.)
I agree that having a talloc code clone inside libosmocore was not
a good idea from us and that we should fix it in the long run. But
this means _only_ requiring an external talloc, killing the
osmocom/core/talloc.h include file. But that is different to the
patches you propose.
For this reason I am not taking your talloc patches. Sorry.
holger