Re: [PATCH] Add vty command for setting Access control classes

2013/7/25 Holger Hans Peter Freyther holger@freyther.de

On Thu, Jul 25, 2013 at 06:19:24PM +0400, Ivan Kluchnikov wrote:

...

• added 'write' implementation

please write a VTY test for this routine. It is like 20 lines of python and will make sure that bitrot is detected early (a perfect way to secure your time investment).

Yes, I agree, tests are very important, I will try to write one for this command.

•   if ((bts->si_common.rach_control.t3) != 0)
  

...

•   if ((bts->si_common.rach_control.t2 & 0xfb) != 0)
  

...

you want to avoid executing the for loop?

Yes, do you think it is redundant part of the code?

holger