two general code review questions