10 May
2016
10 May
'16
9:03 p.m.
From Harald Welte laforge@gnumonks.org:
Harald Welte has posted comments on this change.
Change subject: Set DTX in Cell Options ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
aside from the naming (see comment) it looks fine to me
https://gerrit.osmocom.org/#/c/39/1/include/osmocom/gsm/protocol/gsm_04_08.h File include/osmocom/gsm/protocol/gsm_04_08.h:
Line 474: GSM48_MAY_USE, Naming. GSM48_MAY_USE is very generic, as 04.08 covers all of GSM L3. So unless we intend to use the same enum for other topics, too (which we don't, as it is called gsm48_dtx_mode), it should be called GSM48_{MAY,SHALL,SHALL_NOT}_USE_DTX or GSM48_DTX_{MAY,SHALL,SHALL_NOT}_BE_USED
--
To view, visit https://gerrit.osmocom.org/39
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a8924f57669c951b2e51b663d95f1d360062a54
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max msuraev@sysmocom.de
Gerrit-Reviewer: Harald Welte laforge@gnumonks.org
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes