Re: [PATCH 4/4] nitb: Fix IMSI/IMEI buffer handling (Coverity)

On Tue, Apr 07, 2015 at 05:49:50PM +0200, Jacob Erlbeck wrote:

This commit changes to code to not touch the last byte in the buffers and to rely on the last byte being NUL. So the maximum IMSI/IMEI length is GSM_IMSI_LENGTH-1/GSM_IMEI_LENGTH-1.

For information: "rely" here means.. we assume that we allocate the structure with talloc_zero. This means we have NULed the entire imsi array and then only write sizeof - 1 characters to it. So the last byte remains NUL