Re: [PATCH 2/7] src: more robust ipaccess_idtag_parse()

On 04/12/2011 07:55 PM, Pablo Neira Ayuso wrote:

...

Thanks, IIRC there is another issue here. We assume that the strings on the wire contain a '\0', e.g. in the printf statements we rely on this. So we could either put this in there or do something else.

Can I assume that all IPAC_IDTAG_* are all strings?

I'm sorry. I do not know.

If so, I'll send a patch to check for the trailing \0 to:

dec->lv[t_tag].val = cur;

Sorry, I didn't get you in the first hand, I'm not ignoring your requests :-).

Let me know if this is not what you mean.

It would be good to find out which of these tags have the null termination and which not.

holger