Hi Jaroslav,
On Wed, Nov 11, 2015 at 10:23:11AM -0500, Jaroslav Skarvada wrote:
During the packaging I found following minor issues:
- Incorrect FSF addresses in source code
Patch attempting to fix it is attached.
Patch applied, thanks.
- exit call in the library: /usr/lib64/libosmovty.so.3.0.0 exit@GLIBC_2.2.5
libraries shouldn't generally call exit.
So the best we can do without breaking API and ABI (and modifying all users of the library) is to change the exit(1) calls into an assert. Would that be better?
Nice, thanks. Please note, this is not something that blocks Fedora review, I just wanted to point it out, e.g. to consider it for next API update sometimes in the future
Thanks. I've just applied a patch to change the exit() calls into OSMO_ASSERT() instead, which is a better and more generic way to do this anyway.
The VTY code doesn't get much love from us, we simply adapted it from Zebra back in the early days of OpenBSC, and it sits there without much review/improvement/change.
Regards, Harald