Re: [PATCH 3/3] ussd: Changed 7bit test to check spec conformance directly

On Thu, Aug 08, 2013 at 12:38:54PM +0200, Jacob Erlbeck wrote:

all looks good. thank you for the patches. Some cosmetic nitpick.

• OSMO_ASSERT(!strcmp(encoded_hex, osmo_hexdump_nospc(coded, y)));

we tend to use strcmp == 0.

• gsm_7bit_decode_ussd(decoded, coded, y * 8 / 7); y = strlen(decoded); printf("decoded = %s\n\n", osmo_hexdump((uint8_t *)decoded, y));
• OSMO_ASSERT(!strncmp(text, decoded, strlen (text)));

strlen(text) e.g. no space between the opening parethesis

• OSMO_ASSERT(!strcmp(appended_after_decode, decoded + strlen (text)));

I am going to apply all three patches now.