19 May
2016
19 May
'16
8:37 a.m.
Patch Set 4: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/74/4/src/stats.c File src/stats.c:
Line 357: #ifdef MSG_NOSIGNAL I don't like #ifdefs in code too much. I will let this one in but in general maybe having a
#ifdef __APPLE__ #define MSG_NOSIGNAL 0 #endif
at the top is a better idea? 0 | .. will result in a working bitmask and the problem of SIGPIPE might still be the case not that I think we will hit it here.
--
To view, visit https://gerrit.osmocom.org/74
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I580a500edcf4812e570be586890abef746083a8c
Gerrit-PatchSet: 4
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Arran Cudbard-bell a.cudbardb@freeradius.org
Gerrit-Reviewer: Holger Freyther holger@freyther.de
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes