On Thu, Oct 18, 2012 at 03:09:10PM +0200, Holger Hans Peter Freyther wrote:
On Thu, Oct 18, 2012 at 02:19:43PM +0200, Pablo Neira Ayuso wrote:
I don't want that this becomes a "bikeshed color" discussion [1], I think the code changes are clear enough.
well, there is no way I build a nuclear power plant so the bikeshed is all I have. :)
I kind of agree with peter that a 'break' in the default would be nice. It is just one of the habbits (including me writing code like return X;break;).
Anyway, feel free to commit the leak fixes.
Will do. I'll change that break as you want it before doing so.
PS: I find it amusing how after a month suddenly no day passes without someone saying his nanoBTS is dropped. So I would like to keep the 'dropping' until someone feels encouraged enough to create a PCAP file and we fix the 'bad' return statement.
I pushed the patch to libosmo-abis. I can revert it if you want, or feel free to make it yourself, of course.