27 Oct
2015
27 Oct
'15
10:13 a.m.
On 10/27/2015 08:36 AM, Harald Welte wrote:
The number was just a guestimate, but the existing code was definitely a
great starting point.
Will do, but I think I will have to rework the changesets a bit. There
are a few intermediate commits that can probably be squashed and others
that might have to be split.
Hi Andreas,
good to seee you on the mailing list, and thanks for sharing your work.
On Mon, Oct 26, 2015 at 06:14:19PM +0100, Andreas Schultz wrote:
Great, thanks.
Some time ago, Pablo Neira Ayuso wrote a GTP-U
kernel module and OpenGGSN
support for it. The OpenGGSN side is easily available in the osmocom git [1].
The kernel part is somewhat harder to find, but it's at [2].
This is for historical reasons... I've now moved the kernel part to
http://git.osmocom.org/osmo-gtp-kernel/
and the 'osmocom developers with commit access' can now push to it via
git://gitosis@git.osmocom.org:osmo-gtp-kernel.git It seems that
both sides are at 70% completion and only somewhat working.
I would have expected a higher percentage, but then indeed it is true,
the project got halted / postponed at the time due to changing customer
requirements, as far as I remember I have played
with the kernel module, changed a couple things and would
like to get some feedback on my changes.
It can be found at: https://github.com/RoadRunnr/osmo-ggsn
I think it would be best (and customary practise) to send your changes
to this list (using git format-patch / send-email) for review. After a brief initial review it looks fine to me, but
Pablo is clearly
the better judge of that.
One thing I seem to notice immediaately at a brief look is that it
appears often 8 spaces are used instead of tab for indentation. I know
it's picky, but that has to be adressed before any mainline merge
attempt :/
Oops, bad editor settings combined with cut&paste ;-)
I think you mentioned last week that you still had
some issues with
module unloading ? It would be good to share any remaining problems,
maybe somebody has some idea/input on what is causing the problem.
I've found that, it's fixed in the last commit. The problem was actually
the error handling when the creation of the gtp interface failed.
Please also feel free to add yourself to the list of
Copyright holders
in the file headers, so we have proper documentation of that before
submission.
Will do.
Andreas
Regards,
Harald