11 Dec
2018
11 Dec
'18
8:58 a.m.
On Tue, Dec 11, 2018 at 12:44:34AM +0100, Neels Hofmeyr wrote:
I do think it sucks that it doesn't show the
status properly; you always need
to click around and manually sum up CR votes to see where you're at. It's
quite a half-arsed implementation, little more than a quick example.
Well... We are doing code review via a *web interface*
So what else would you expect?
Oh, BTW, do some people still get the right to +2, so
that actually only two
reviews are needed if one of them voted +2? Or does everyone only +1 now?
(easy to configure and enforce)
Current +2 / +1 vote token assignments shouldn't change.
This was never explicitly discussed, but it was implied.