On Thu, Nov 21, 2013 at 07:05:45PM +0100, Jacob Erlbeck wrote:
The current implementation increments the seqno but does not increment the RTP timestamp, leading to two identical timestamps following one after the other.
thanks for spotting this!
+/* Assume audio frame length of 20ms */ +#define RTP_AUDIO_FRAME_DUR_NUM 20 +#define RTP_AUDIO_FRAME_DUR_DEN 1000 +#define RTP_AUDIO_DEFAULT_RATE 8000
can't we initialize the rate in mgcp_rtp_end_init or such? This way we know that this is either default or (read from the SDP file).
state->patch = endp->allow_patch;-TS: 2040, dTS: 160, TS Errs: in 5, out 6 +TS: 1880, dTS: 160, TS Errs: in 5, out 5
state->patch is most likely 0 here but we do patch things. Now we might want to fix the tsdelta in all cases but then I think we should rename state->patch to state->patch_ssrc (or state->patch_stream_change)?
what do you think?