Patch Set 2:
(3 comments)
https://gerrit.osmocom.org/#/c/145/2//COMMIT_MSG Commit Message:
Line 9: rlc.dl_bytes bytes before sending rlc "before sending"? Doesn't 'dl' mean 'downloaded'?
Line 15: it would be good to have this explanation of counter items as comment in the code instead, because it is very helpful and should not be "hidden" in a commit log.
https://gerrit.osmocom.org/#/c/145/2/src/bts.cpp File src/bts.cpp:
Line 79: { "rlc.ul_payload_bytes", "RLC UL Payload Bytes "}, I'd prefer if DL and UL were spelled out, because of limited space I'd shorten 'Bytes' to 'b' instead. If it's not enough space maybe use 'haul' instead of 'payload'?
Or use 'recvd' and 'sent' instead of DL and UL? The item just above used 'sent', so actually we should stay with that.
It is about 'sent' and 'received' bytes, isn't it? Or did I get this wrong entirely? Anyway, I'd prefer it spelled out :)