From Holger Freyther holger@freyther.de:
Holger Freyther has posted comments on this change.
Change subject: Add selector for ANSI or ITU variant ......................................................................
Patch Set 1:
This is for initial review. Wouldn't expect this to be merged as is (needs tests for a start).
More to get feedback on whether ANSI support is desired. In the project we're doing currently it is. I have similar patches for the MTP3 layer in osmobsc, but there needs to be more discussion around that.
Yes, ANSI (and Japan, China?) would be nice to have (for being complete). I don't know much about the differences of ANSI SCCP.
In general: * It should not break ITU support * It should not make code more ugly/slower (not saying the patch does) * ANSI code should have test cases by itself (and preferable make traces available, e.g. to the wireshark Sample Captures).