Re: [PATCH 2/4] vty: Hide unconfigured BTS on 'write'

On 09/12/2013 05:23 AM, Peter Stuge wrote:

My personal taste is to test all required conditions and exit early if they aren't met.

That way, it's easy to get an overview of all conditions, before the "meat" of the function takes place. It also avoids one level of nesting for each condition. The patch would in this case become quite simple:

• if (!bts->model)

•    return;
  
  

(Maybe even if (!bts || !bts->model) ..)

I agree, that's much better. Thanks for looking into it.

Jacob